Add Azure Data Link Layer assurance and MACsec checks - #247
Open
ritiksah141 wants to merge 3 commits into
Open
Conversation
Signed-off-by: ritiksah141 <ritiksah141@gmail.com>
ritiksah141
requested review from
SHAURYAKSHARMA24,
TFT444,
Vishnu2707 and
parthrohit22
as code owners
August 10, 2026 22:49
Signed-off-by: ritiksah141 <ritiksah141@gmail.com>
TFT444
requested changes
Aug 10, 2026
TFT444
left a comment
Collaborator
There was a problem hiding this comment.
Hey @ritiksah141 , the PR looks good overall, but it needs a few fixes before merging. Please change macsec_config to the real Azure SDK field mac_sec_config, add a test using the correct SDK object structure, use each ExpressRoute link’s unique ID in findings, and keep API failures clearly indeterminate instead of treating them like empty inventory.
Signed-off-by: ritiksah141 <ritiksah141@gmail.com>
Collaborator
Author
|
@TFT444, the PR Implemented the requested changes in
Local verification: 529 passed, 2 skipped; Ruff, format, and Bandit pass. |
TFT444
approved these changes
Aug 10, 2026
TFT444
left a comment
Collaborator
There was a problem hiding this comment.
all the fixes are done from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Azure public-cloud Data Link Layer assurance with complete LLC and MAC coverage plus customer-actionable ExpressRoute Direct MACsec checks.
What changed
GET /api/assurance/data-link-layerreporting with separate catalog coverage and evidence freshness.AZ-DL-001for enabled ExpressRoute Direct links without MACsec.AZ-DL-002for ExpressRoute Direct ports of 40 Gbps or greater using a non-XPN cipher.AZ-DLnamespace andData Linkcategory so the controls cannot be confused with OSI Layer 3 rules.Verification
Type of change
Testing
Checklist
Signed-off-bytrailerCloses #241